-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(location): adjust zipCode nullish checks #3080
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3080 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2776 2776
Lines 226260 226262 +2
Branches 591 592 +1
==========================================
- Hits 226206 226193 -13
- Misses 54 69 +15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not complain about this change, but has this been a problem before? Is there a GH issue I didn't notice?
No, its only for consistency with our other code. |
This PR changes the implementation of zipCode to replace the falsy checks with explicit nullish checks.