Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(number): add romanNumeral method #3070

Merged
merged 18 commits into from
Oct 31, 2024
Merged

feat(number): add romanNumeral method #3070

merged 18 commits into from
Oct 31, 2024

Commits on Aug 22, 2024

  1. Added romanNumeral function (draft)

    @AmaanRS
    AmaanRS committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b06942e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Changed to a new logic for generating roman numeral

    @AmaanRS
    AmaanRS committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7abd2c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Wrote tests for roman numeral function

    @AmaanRS
    AmaanRS committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f0dc31c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Removed unnecessary checks and tests

    @AmaanRS
    AmaanRS committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    48b0a53 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'next' into feat/numberToRomanNumerals

    @matthewmayer
    matthewmayer authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dbb0f71 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Removed string link

    @AmaanRS
    AmaanRS committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e685dbb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feat/numberToRomanNumerals' of https://github.com/Amaan… 

    …RS/faker into feat/numberToRomanNumerals
    @AmaanRS
    AmaanRS committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    57a8a0d View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Ran prefilght once more

    @AmaanRS
    AmaanRS committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fb538f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Used default values while destructuring options parameter

    @AmaanRS
    AmaanRS committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d8efc5d View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Made changes according to the review

    @AmaanRS
    AmaanRS committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    7af0c8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into feat/numberToRomanNumerals

    @AmaanRS
    AmaanRS authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9ac3c1c View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Created a function named roman numeral in faker.number to generate an… 

    … random roman numeral
    @AmaanRS
    AmaanRS committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    2cf192a View commit details
    Browse the repository at this point in the history

  2. chore: revert temp test config

    @ST-DDT
    ST-DDT committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    b007374 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge branch 'next' into feat/numberToRomanNumerals

    @ST-DDT
    ST-DDT authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3f1bce8 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Merge branch 'next' into feat/numberToRomanNumerals

    @ST-DDT
    ST-DDT authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    5288130 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Update src/modules/number/index.ts

    @ST-DDT
    ST-DDT authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7f30cdf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into feat/numberToRomanNumerals

    @ST-DDT
    ST-DDT authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4996595 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge branch 'next' into feat/numberToRomanNumerals

    @ST-DDT
    ST-DDT authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6e04bef View commit details
    Browse the repository at this point in the history