Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add chat.fakerjs.dev subdomain redirection to discord #306

Merged
merged 3 commits into from
Jan 28, 2022
Merged

feat: add chat.fakerjs.dev subdomain redirection to discord #306

merged 3 commits into from
Jan 28, 2022

Conversation

import-brain
Copy link
Member

Fixes #295

Shinigami92
Shinigami92 requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to replace all links like in markdown files with new url

@Shinigami92 Shinigami92 marked this pull request as draft January 26, 2022 06:17
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 26, 2022
@import-brain
Copy link
Member Author

You need to replace all links like in markdown files with new url

Could you please clarify what you mean by this? I interpreted your instructions as "replace all instances of fakerjs.dev with chat.fakerjs.dev in markdown files", but I don't think that makes sense.

@Shinigami92
Copy link
Member

faker/README.md

Line 6 in 3242dfc

[![Chat on Discord](https://img.shields.io/discord/929487054990110771)](https://discord.com/invite/4qDjAmDj4P)

Just one example, please search over the whole repo

@import-brain
Copy link
Member Author

import-brain commented Jan 26, 2022 •
edited
Loading

3242dfc/README.md?plain=1#L6

Just one example, please search over the whole repo

Ohhh I see, will do.

Edit: done

@import-brain import-brain marked this pull request as ready for review January 26, 2022 18:18
@import-brain import-brain marked this pull request as draft January 26, 2022 18:19
@import-brain import-brain marked this pull request as ready for review January 26, 2022 18:20
@import-brain
Copy link
Member Author

Whoops, misclick.

ST-DDT
ST-DDT reviewed Jan 26, 2022
View reviewed changes
netlify.toml Outdated Show resolved Hide resolved
@import-brain @ST-DDT
Update netlify.toml
8363374 
Co-authored-by: ST-DDT <[email protected]>
@ST-DDT ST-DDT requested a review from a team January 26, 2022 20:01
@Shinigami92 Shinigami92 merged commit 32b4839 into faker-js:main Jan 28, 2022
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@import-brain @ST-DDT @bmenant
feat: add chat.fakerjs.dev subdomain redirection to discord (faker-js…
b9759e7 
…#306)

Co-authored-by: ST-DDT <[email protected]>
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@import-brain @ST-DDT @demipel8
feat: add chat.fakerjs.dev subdomain redirection to discord (faker-js…
c265e4a 
…#306)

Co-authored-by: ST-DDT <[email protected]>
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@import-brain @ST-DDT @demipel8
feat: add chat.fakerjs.dev subdomain redirection to discord (faker-js…
d864094 
…#306)

Co-authored-by: ST-DDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@damienwebdev damienwebdev Awaiting requested review from damienwebdev

@prisis prisis Awaiting requested review from prisis

Assignees

@import-brain import-brain

Labels
p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chat.fakerjs.dev
3 participants
@import-brain @Shinigami92 @ST-DDT