Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove mocks from system #303

Merged
merged 18 commits into from
Jan 31, 2022
Merged

test: remove mocks from system #303

merged 18 commits into from
Jan 31, 2022

Conversation

prisis
Copy link
Member

@prisis prisis commented Jan 25, 2022

No description provided.

@prisis prisis requested a review from a team as a code owner January 25, 2022 22:31
@prisis
Copy link
Member Author

prisis commented Jan 25, 2022

now we have correct tests for system and #300 is valid

prisis
prisis commented Jan 25, 2022
View reviewed changes
test/system.spec.ts Outdated Show resolved Hide resolved
@prisis prisis self-assigned this Jan 25, 2022
@prisis prisis added this to the v6.0.0 - Project stability milestone Jan 25, 2022
@Shinigami92 Shinigami92 marked this pull request as draft January 25, 2022 22:40
Shinigami92
Shinigami92 requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the already existing test cases, rewrite them, modernize them and move them to the seeded or non-seeded section

@Shinigami92 Shinigami92 mentioned this pull request Jan 26, 2022
Closed
@prisis prisis marked this pull request as ready for review January 26, 2022 09:20
ST-DDT
ST-DDT requested changes Jan 26, 2022
View reviewed changes
test/system.spec.ts Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 reviewed Jan 26, 2022
View reviewed changes
test/system.spec.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 reviewed Jan 26, 2022
View reviewed changes
test/system.spec.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 reviewed Jan 26, 2022
View reviewed changes
test/system.spec.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 marked this pull request as draft January 26, 2022 11:09
@prisis prisis marked this pull request as ready for review January 29, 2022 07:30
Shinigami92
Shinigami92 requested changes Jan 29, 2022
View reviewed changes
test/system.spec.ts Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
test/system.spec.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes Jan 29, 2022
View reviewed changes
@ST-DDT ST-DDT mentioned this pull request Jan 29, 2022
Merged
ST-DDT
ST-DDT previously approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort the seeded and non seeded tests in the same order next time.
Optimally in alphabetical order.

@Shinigami92 Shinigami92 mentioned this pull request Jan 30, 2022
Merged
@prisis prisis dismissed stale reviews from ST-DDT and Shinigami92 via 4e05c14 January 30, 2022 21:23
Shinigami92
Shinigami92 previously approved these changes Jan 31, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested review from griest024, ST-DDT and a team January 31, 2022 08:06
ST-DDT
ST-DDT requested changes Jan 31, 2022
View reviewed changes
test/system.spec.ts Outdated Show resolved Hide resolved
@prisis
Copy link
Member Author

prisis commented Jan 31, 2022

Please sort the seeded and non seeded tests in the same order next time. Optimally in alphabetical order.

done  :)

@Shinigami92 Shinigami92 requested review from ST-DDT, Shinigami92 and a team January 31, 2022 18:55
@Shinigami92 Shinigami92 merged commit 8bb1e6c into faker-js:main Jan 31, 2022
@prisis prisis deleted the feauter/fix-system-tests branch January 31, 2022 21:46
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@prisis @bmenant
test: remove mocks from system (faker-js#303)
9613766
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@prisis @demipel8
test: remove mocks from system (faker-js#303)
c57bd7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@griest024 griest024 Awaiting requested review from griest024

Assignees

@prisis prisis

Labels
c: test
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
5 participants
@prisis @ST-DDT @griest024 @Shinigami92 @import-brain