Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove usage of vitest.todo #2960

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jun 20, 2024

This removes all usages of vitest.todo.

  • The disabled test is obsolete and there is no point in enabling it again at this time.
  • The seededTest-factories' todo method isn't in use and I don't see a reason why it should be used for any new features going forward.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Jun 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jun 20, 2024
@ST-DDT ST-DDT requested review from a team June 20, 2024 12:48
@ST-DDT ST-DDT self-assigned this Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit 2c9e815
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66783dc75dffeb000849d968

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (4514fce) to head (2c9e815).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2960      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.02%     
==========================================
  Files        2989     2989              
  Lines      216081   216081              
  Branches      600      948     +348     
==========================================
- Hits       216006   215981      -25     
- Misses         75      100      +25     

see 1 file with indirect coverage changes

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not, so sure about this, but wont block

@ST-DDT ST-DDT requested a review from a team June 20, 2024 14:04
@ST-DDT ST-DDT enabled auto-merge (squash) June 23, 2024 15:23
@ST-DDT ST-DDT merged commit 6b1159d into next Jun 23, 2024
23 checks passed
@ST-DDT ST-DDT deleted the test/remove-obsolete-disabled branch June 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants