-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale)!: use snake case for all locale data #2910
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2910 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 2977 2977
Lines 215421 215421
Branches 948 951 +3
=======================================
+ Hits 215327 215333 +6
+ Misses 94 88 -6
|
Why do we couple file anme and property key anyway? The propblem I have right now is that we have locale entries which might be lists of objects which intern have property keys as well. These are not considered in the PR. For example, look at
|
Because the index files that merge them are generated. We could transform the property keys in between, but it would be a massive breaking change. Sure we could do that, but we should talk about it first. |
If you are just concerned about the wording, I can change it to refer to locale categories and entries specifically. |
Thats propably it for me. Alternativly we could actually make all properties snake_case. The definition properties which are not "correctly" cased right now (ignoring the ones from this PR) are:
|
Standardize file naming convention for the renaming locale files.
faker.definitions.science.chemicalElement
faker.definitions.science.chemical_element
faker.definitions.system.directoryPaths
faker.definitions.system.directory_paths
faker.definitions.system.mimeTypes
faker.definitions.system.mime_types
This is an attempt an fixing some TODOs in our sources.