Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): activate data normalization for airline #2828

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265

Normalize the entries in the airline module definitions in all locales.

I choose this module because all data entries are lists of objects and we did decide against object key sorting for now. That means that changes are little to none.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: airline Something is referring to the airline module labels Apr 15, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team April 15, 2024 20:22
@xDivisionByZerox xDivisionByZerox self-assigned this Apr 15, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner April 15, 2024 20:22
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit fb22018
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/661d9f1707e6dd00081367c0
😎 Deploy Preview https://deploy-preview-2828.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (cd5577c) to head (fb22018).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2828      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2964     2964              
  Lines      212556   212541      -15     
  Branches      601      946     +345     
==========================================
- Hits       212486   212465      -21     
- Misses         70       76       +6     
Files Coverage Δ
src/locales/zh_CN/airline/airport.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox force-pushed the locale/activate-data-normalization-for-airline branch from 24c3aeb to a2d6130 Compare April 15, 2024 20:41
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 15, 2024
@ST-DDT ST-DDT requested a review from a team April 15, 2024 21:41
@Shinigami92 Shinigami92 merged commit d71662e into next Apr 16, 2024
20 checks passed
@Shinigami92 Shinigami92 deleted the locale/activate-data-normalization-for-airline branch April 16, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: airline Something is referring to the airline module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants