Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): extend Uzbek locale for date and color #2724

Merged
merged 11 commits into from
Mar 15, 2024
Merged

feat(locale): extend Uzbek locale for date and color #2724

merged 11 commits into from
Mar 15, 2024

Conversation

Mirazyzz
Copy link
Contributor

@Mirazyzz Mirazyzz commented Mar 7, 2024

No description provided.

@Mirazyzz Mirazyzz requested a review from a team as a code owner March 7, 2024 07:53
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (a409b46) to head (6844c08).

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2724    +/-   ##
========================================
  Coverage   99.57%   99.57%            
========================================
  Files        2974     2979     +5     
  Lines      250273   250372    +99     
  Branches      983      984     +1     
========================================
+ Hits       249199   249308   +109     
+ Misses       1074     1064    -10
Files Coverage Δ
src/locales/uz_UZ_latin/color/human.ts 100.00% <100.00%> (ø)
src/locales/uz_UZ_latin/color/index.ts 100.00% <100.00%> (ø)
src/locales/uz_UZ_latin/date/index.ts 100.00% <100.00%> (ø)
src/locales/uz_UZ_latin/date/month.ts 100.00% <100.00%> (ø)
src/locales/uz_UZ_latin/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/uz_UZ_latin/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

ST-DDT
ST-DDT reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do the actual review later, when I have some more free time.

FFR: Please only do one module per PR to make things easier to review.

In this case I think it is OK, but keep that in mind for future PRs.

src/locales/uz_UZ_latin/phone_number/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT changed the title feat(locale): extend locale feat(locale): extend Uzbek locale Mar 7, 2024
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module m: color Something is referring to the color module labels Mar 7, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Mar 7, 2024
matthewmayer
matthewmayer requested changes Mar 7, 2024
View reviewed changes
src/locales/uz_UZ_latin/color/human.ts Outdated Show resolved Hide resolved
src/locales/uz_UZ_latin/date/weekday.ts Outdated Show resolved Hide resolved
src/locales/uz_UZ_latin/date/weekday.ts Outdated Show resolved Hide resolved
@matthewmayer
Copy link
Contributor

I'll do the actual review later, when I have some more free time.

FFR: Please only do one module per PR to make things easier to review.

In this case I think it is OK, but keep that in mind for future PRs.

Also please put the module(s) in the PR title eg

Extend Uzbek locale for date and color

@Mirazyzz Mirazyzz changed the title feat(locale): extend Uzbek locale feat(locale): extend Uzbek locale for date and color Mar 12, 2024
ST-DDT
ST-DDT reviewed Mar 12, 2024
View reviewed changes
src/locales/uz_UZ_latin/color/human.ts Outdated Show resolved Hide resolved
src/locales/uz_UZ_latin/color/human.ts Show resolved Hide resolved
src/locales/uz_UZ_latin/date/month.ts Show resolved Hide resolved
@Mirazyzz
Copy link
Contributor Author

@ST-DDT @matthewmayer what is the reason for the build to fail?

@ST-DDT
Copy link
Member

ST-DDT commented Mar 12, 2024

what is the reason for the build to fail?

An issue with codecov itself, that is unrelated to this PR.

ST-DDT
ST-DDT previously approved these changes Mar 12, 2024
View reviewed changes
@ST-DDT ST-DDT requested review from matthewmayer and a team March 12, 2024 15:38
Shinigami92
Shinigami92 previously approved these changes Mar 12, 2024
View reviewed changes
@Mirazyzz Mirazyzz dismissed stale reviews from Shinigami92 and ST-DDT via d127227 March 14, 2024 20:27
@Mirazyzz
Copy link
Contributor Author

Apologies, instead of pushing to a new branch I pushed to the old...
2323

@ST-DDT
Copy link
Member

ST-DDT commented Mar 14, 2024

Apologies, instead of pushing to a new branch I pushed to the old...

No problem. We are just waiting for a review from @matthewmayer, and then this can be merged.

@ST-DDT ST-DDT requested review from Shinigami92 and a team March 14, 2024 20:38
@ST-DDT ST-DDT merged commit 776a625 into faker-js:next Mar 15, 2024
16 checks passed
@WontonSam WontonSam mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@Mirazyzz Mirazyzz

Labels
c: locale Permutes locale definitions m: color Something is referring to the color module m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@Mirazyzz @matthewmayer @ST-DDT @Shinigami92