Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(netlify): enable deploy previews #2715

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 4, 2024

Fixes #815

While technically not "on demand", this should sufficiently reduce (prevent) builds to not run into build-minute limits.


After this PR is merged, the feature has to be enabled in netlify.

Active Deploy Preview: ST-DDT#3
Skipped Deploy Preview: ST-DDT#4

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Mar 4, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Mar 4, 2024
@ST-DDT ST-DDT requested review from a team March 4, 2024 21:58
@ST-DDT ST-DDT self-assigned this Mar 4, 2024
netlify.toml Show resolved Hide resolved
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (8c80877) to head (5478bb1).

❗ Current head 5478bb1 differs from pull request most recent head ff13f18. Consider uploading reports for the commit ff13f18 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2715      +/-   ##
==========================================
- Coverage   99.56%   99.56%   -0.01%     
==========================================
  Files        2979     2979              
  Lines      250229   250372     +143     
  Branches      981      630     -351     
==========================================
+ Hits       249149   249290     +141     
- Misses       1051     1082      +31     
+ Partials       29        0      -29     

see 31 files with indirect coverage changes

@Shinigami92
Copy link
Member

Is it somehow possible to read a GitHub Label from the PR via netlify and when it exists, then do a preview?

@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 5, 2024

Is it somehow possible to read a GitHub Label from the PR via netlify and when it exists, then do a preview?

Unfortunately not (yet).

@Shinigami92
Copy link
Member

Is it somehow possible to read a GitHub Label from the PR via netlify and when it exists, then do a preview?

Unfortunately not (yet).

Could we discuss in a meeting about this? How does it work? What are the downsides to consider? Can / Should we contact someone from netlify to ask if this is the best approach or if there is something better? and so on...

@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 5, 2024

Could we discuss in a meeting about this?

sure

Can / Should we contact someone from netlify to ask if this is the best approach or if there is something better?

We aren't the first asking for that feature.

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Mar 5, 2024
@xDivisionByZerox
Copy link
Member

Team Decision

We will merge this and reevaluate this in a month.

@xDivisionByZerox xDivisionByZerox removed the s: needs decision Needs team/maintainer decision label Mar 14, 2024
@ST-DDT ST-DDT requested a review from a team March 14, 2024 17:36
@ST-DDT ST-DDT enabled auto-merge (squash) March 15, 2024 16:24
@ST-DDT ST-DDT merged commit 2a50c76 into faker-js:next Mar 15, 2024
14 checks passed
@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 15, 2024

Deploy previews enabled.

@ST-DDT ST-DDT deleted the docs/netlify/deploy-preview branch March 15, 2024 16:49
@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 15, 2024

But it looks like I have to tweak the condition some more, so that "update from next" does not trigger a preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make possible to preview docs of a PR on demand via netlify-preview
3 participants