-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(netlify): enable deploy previews #2715
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2715 +/- ##
==========================================
- Coverage 99.56% 99.56% -0.01%
==========================================
Files 2979 2979
Lines 250229 250372 +143
Branches 981 630 -351
==========================================
+ Hits 249149 249290 +141
- Misses 1051 1082 +31
+ Partials 29 0 -29 |
Is it somehow possible to read a GitHub Label from the PR via netlify and when it exists, then do a preview? |
Unfortunately not (yet). |
Could we discuss in a meeting about this? How does it work? What are the downsides to consider? Can / Should we contact someone from netlify to ask if this is the best approach or if there is something better? and so on... |
sure
We aren't the first asking for that feature. |
Team Decision We will merge this and reevaluate this in a month. |
Deploy previews enabled. |
But it looks like I have to tweak the condition some more, so that "update from next" does not trigger a preview. |
Fixes #815
While technically not "on demand", this should sufficiently reduce (prevent) builds to not run into build-minute limits.
After this PR is merged, the feature has to be enabled in netlify.
Active Deploy Preview: ST-DDT#3
Skipped Deploy Preview: ST-DDT#4