refactor!: remove v8 deprecated faker class stuff #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
p: 1-normal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2682 +/- ##
==========================================
+ Coverage 99.55% 99.56% +0.01%
==========================================
Files 2816 2816
Lines 250918 250683 -235
Branches 706 1101 +395
==========================================
- Hits 249807 249599 -208
- Misses 1082 1084 +2
+ Partials 29 0 -29
|
Shinigami92
force-pushed
the
remove-deprecated-faker-class-things
branch
from
2d6e0bc
to
f0d67a1
Compare
ST-DDT
reviewed
Feb 24, 2024
ST-DDT
approved these changes
Feb 24, 2024
matthewmayer
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #2608