-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update pnpm-lock #2631
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2631 +/- ##
==========================================
- Coverage 99.57% 99.56% -0.01%
==========================================
Files 2807 2807
Lines 250452 250452
Branches 1152 1147 -5
==========================================
- Hits 249390 249372 -18
- Misses 1034 1052 +18
Partials 28 28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future we should let renovate do this, but I just want the warning gone.
Isn't u/dependabot the bot that usually creates security auto fix PR's?
That could be right 🤔 Normally in that case de-duplication takes place if possible. Edit: We do have v5 and v4 in our dependency-tree. I'm not totally sure what you are referring to now. Maybe lets talk later on Discord to show and clarify what the problems are. |
The issue is that dependabot does not create a fix PR itself and I had to do that myself. There is no problem with this PR itself. |
This PR hopefully fixes the irrelevant warning during push:
https://github.com/faker-js/faker/security/dependabot/16
For the future we should let renovate do this, but I just want the warning gone.