Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(internet): fix typos in deprecation warnings for internet #2613

Merged
merged 3 commits into from
Jan 24, 2024
Merged

docs(internet): fix typos in deprecation warnings for internet #2613

merged 3 commits into from
Jan 24, 2024

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Jan 21, 2024 •
edited
Loading

Minor errors in deprecation comments.

@matthewmayer matthewmayer requested a review from a team as a code owner January 21, 2024 12:37
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fce907) 99.56% compared to head (77a67e6) 99.57%.
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2613   +/-   ##
=======================================
  Coverage   99.56%   99.57%           
=======================================
  Files        2807     2807           
  Lines      250452   250452           
  Branches     1151     1151           
=======================================
+ Hits       249375   249389   +14     
+ Misses       1049     1035   -14     
  Partials       28       28
Files Coverage Δ
src/modules/internet/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@matthewmayer matthewmayer changed the title docs(internet): fix typo in deprecation warning for internet.color docs(internet): fix typos in deprecation warning for internet Jan 21, 2024
@matthewmayer matthewmayer changed the title docs(internet): fix typos in deprecation warning for internet docs(internet): fix typos in deprecation warnings for internet Jan 21, 2024
@matthewmayer matthewmayer self-assigned this Jan 21, 2024
@matthewmayer matthewmayer added the c: docs Improvements or additions to documentation label Jan 21, 2024
@ST-DDT ST-DDT added this to the v8.x milestone Jan 21, 2024
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Jan 21, 2024
@ST-DDT ST-DDT requested review from a team January 21, 2024 13:03
@ST-DDT ST-DDT added the m: internet Something is referring to the internet module label Jan 21, 2024
@Shinigami92 Shinigami92 enabled auto-merge (squash) January 24, 2024 17:21
@Shinigami92 Shinigami92 merged commit 5518688 into next Jan 24, 2024
18 checks passed
@ST-DDT ST-DDT deleted the fix-internet-color-deprecation branch February 5, 2024 22:12
@dagistan-tuncbilek dagistan-tuncbilek mentioned this pull request Jun 14, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Merged
@sindhuhack sindhuhack mentioned this pull request Sep 24, 2024
Open
@jiisuominen jiisuominen mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation m: internet Something is referring to the internet module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewmayer @ST-DDT @Shinigami92