-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify that location.state refers to ISO 3166-2 #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import-brain
added
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
m: location
Something is referring to the location module
labels
Dec 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2574 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 2806 2806
Lines 250192 250195 +3
Branches 1107 1107
=======================================
+ Hits 249137 249142 +5
+ Misses 1027 1025 -2
Partials 28 28
|
xDivisionByZerox
approved these changes
Dec 11, 2023
Does this also fixes #1944 |
ST-DDT
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put these description parts also on the locale definitions?
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
m: location
Something is referring to the location module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2360
This PR makes the docs of
location.state()
slightly more precise by explaining that the method generally returns the ISO 3166-2 subdivisions for a country.