-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(helpers): fix examples on internal functions #2559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
Improvements or additions to documentation
c: chore
PR that doesn't affect the runtime behavior
p: 1-normal
Nothing urgent
m: helpers
Something is referring to the helpers module
labels
Nov 25, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2559 +/- ##
=======================================
Coverage 99.57% 99.58%
=======================================
Files 2805 2805
Lines 250166 250168 +2
Branches 1103 1108 +5
=======================================
+ Hits 249101 249120 +19
+ Misses 1037 1020 -17
Partials 28 28
|
xDivisionByZerox
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you create this due to the comments in #2557? Good catch, tho 👍
import-brain
approved these changes
Nov 30, 2023
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: chore
PR that doesn't affect the runtime behavior
c: docs
Improvements or additions to documentation
m: helpers
Something is referring to the helpers module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some very minor cleanup of jsdocs on internal functions.
Found during the review of: #2557