-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(unicorn): prefer-top-level-await #2511
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2511 +/- ##
=======================================
Coverage 99.58% 99.59%
=======================================
Files 2823 2823
Lines 255497 255497
Branches 1099 1105 +6
=======================================
+ Hits 254437 254452 +15
+ Misses 1032 1017 -15
Partials 28 28 |
Can we not actually enable this rule and put the PR "on hold" until we switched? Don't see the advantage of providing the comment in the sourcecode right now, as it is more likely to be forgotten. |
I would like to finish the unicorn list now and fix the "other/later" list of things that need to be in v9 in v9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to finish the unicorn list now and fix the "other/later" list of things that need to be in v9 in v9.
Please note that the switch to ESM main may or may not be in v9 at the earliest and I don't want to carry open PRs for extended periods of time.
I see.
Ref: #2439
Temporarily disables the
unicorn/prefer-top-level-await
lint rule.