Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-top-level-await #2511

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 27, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 27, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 27, 2023
@ST-DDT ST-DDT requested review from a team October 27, 2023 22:10
@ST-DDT ST-DDT self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2511 (3d7ffb5) into next (3ab23b5) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2511   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255497   255497           
  Branches     1099     1105    +6     
=======================================
+ Hits       254437   254452   +15     
+ Misses       1032     1017   -15     
  Partials       28       28           

see 3 files with indirect coverage changes

@xDivisionByZerox
Copy link
Member

Can we not actually enable this rule and put the PR "on hold" until we switched? Don't see the advantage of providing the comment in the sourcecode right now, as it is more likely to be forgotten.

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 28, 2023

I would like to finish the unicorn list now and fix the "other/later" list of things that need to be in v9 in v9.
Please note that the switch to ESM main may or may not be in v9 at the earliest and I don't want to carry open PRs for extended periods of time.

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to finish the unicorn list now and fix the "other/later" list of things that need to be in v9 in v9.
Please note that the switch to ESM main may or may not be in v9 at the earliest and I don't want to carry open PRs for extended periods of time.

I see.

@ST-DDT ST-DDT enabled auto-merge (squash) October 29, 2023 14:24
@ST-DDT ST-DDT merged commit a83db8b into next Oct 29, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-top-level-await branch October 29, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants