Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-native-coercion-functions #2445

Merged
merged 12 commits into from
Oct 23, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 7, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 7, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 7, 2023
@ST-DDT ST-DDT requested review from a team October 7, 2023 20:39
@ST-DDT ST-DDT self-assigned this Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #2445 (9d92e89) into next (c591880) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2445      +/-   ##
==========================================
- Coverage   99.59%   99.57%   -0.02%     
==========================================
  Files        2823     2823              
  Lines      255520   255520              
  Branches     1107     1097      -10     
==========================================
- Hits       254491   254444      -47     
- Misses       1001     1048      +47     
  Partials       28       28              

see 1 file with indirect coverage changes

@matthewmayer
Copy link
Contributor

The changes don't seem related to this rule?

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 8, 2023

The first line is not. Should I revert it?
The second one is.

@ST-DDT ST-DDT enabled auto-merge (squash) October 23, 2023 12:26
@ST-DDT ST-DDT merged commit b083836 into next Oct 23, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-native-coercion-functions branch November 9, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants