Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate en to ts #236

Closed
wants to merge 2 commits into from
Closed

Conversation

doughlass
Copy link
Contributor

Migrated the en directory of locales to ts and fixed broken type definitions and added new ones.

@doughlass doughlass requested a review from a team as a code owner January 19, 2022 21:42
@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 443176b

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e885c832ee7a0008c32837

😎 Browse the preview: https://deploy-preview-236--vigilant-wescoff-04e480.netlify.app

@doughlass doughlass changed the title Migrate en to ts chore: Migrate en to ts Jan 19, 2022
@import-brain import-brain added the c: chore PR that doesn't affect the runtime behavior label Jan 19, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Jan 19, 2022

Please note, that I started #238 to automatically migrate these files.

@Shinigami92
Copy link
Member

@doughlass please wait until @ST-DDT's PR is merged and then apply your improvements
It would be anyway a good idea to split migrations from adding enhancements

@Shinigami92
Copy link
Member

... and fixed broken type definitions and added new ones.

Could you please open a new PR? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants