Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-enable failing test on windows #224

Closed
wants to merge 1 commit into from
Closed

fix: re-enable failing test on windows #224

wants to merge 1 commit into from

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 18, 2022

I tried running the tests in my fork and it worked pretty fine when running there.
ST-DDT#1

@netlify
Copy link

netlify bot commented Jan 18, 2022 •
edited
Loading

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 1ee40db

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e86578c288e400088aef27

😎 Browse the preview: https://deploy-preview-224--vigilant-wescoff-04e480.netlify.app

@Shinigami92 Shinigami92 self-requested a review January 18, 2022 22:33
@Shinigami92 Shinigami92 added c: bug Something isn't working p: 2-high Fix main branch c: test labels Jan 18, 2022
@Shinigami92 Shinigami92 linked an issue Jan 18, 2022 that may be closed by this pull request
Test: Fix failing test finance in win32 system #223
Closed
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 18, 2022 •
edited
Loading

For some reason this seems to be working fine now.
Maybe we should wait a bit and rerun the pipeline later to ensure this isn't a flaky test result.
(I had a similar problem with one of my java applications before. The docker host ran into performance + port issues causing the tests to fail, but those failures were distributed more randomly)

Shinigami92
Shinigami92 previously approved these changes Jan 18, 2022
View reviewed changes
poyea
poyea previously approved these changes Jan 19, 2022
View reviewed changes
Copy link

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainers can re-run the jobs in the Actions tab in the future, if it's failing for some weird reasons (considering there's a large amount of individual tests).

@ST-DDT ST-DDT dismissed stale reviews from poyea and Shinigami92 via 8efe060 January 19, 2022 19:14
@ST-DDT ST-DDT requested a review from a team as a code owner January 19, 2022 19:14
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 19, 2022

FFR: The test is failing at 19:26:27 UTC

@ST-DDT ST-DDT mentioned this pull request Jan 20, 2022
Merged
6 tasks
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 20, 2022

FFR: The test succeeded at 09:21 MEZ

@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 20, 2022

This probably gets obsolete once #235 is merged.

@ST-DDT ST-DDT mentioned this pull request Jan 20, 2022
Merged
@ST-DDT ST-DDT deleted the fix/issue223 branch January 21, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea left review comments

@Shinigami92 Shinigami92 Shinigami92 left review comments

Assignees

@ST-DDT ST-DDT

Labels
c: bug Something isn't working c: test p: 2-high Fix main branch
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.

Test: Fix failing test finance in win32 system
3 participants
@ST-DDT @Shinigami92 @poyea