Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(location): mention real cities #2118

Merged
merged 4 commits into from
May 4, 2023
Merged

docs(location): mention real cities #2118

merged 4 commits into from
May 4, 2023

Conversation

xDivisionByZerox
Copy link
Member

As described in #2021 (comment).

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: location Something is referring to the location module labels May 2, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team May 2, 2023 08:00
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner May 2, 2023 08:00
@xDivisionByZerox xDivisionByZerox self-assigned this May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023 •
edited
Loading

Codecov Report

Merging #2118 (ba12d91) into next (2e9ed96) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ba12d91 differs from pull request most recent head bb4fb15. Consider uploading reports for the commit bb4fb15 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2118      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2605     2605              
  Lines      244951   244944       -7     
  Branches     1251     1249       -2     
==========================================
- Hits       243961   243950      -11     
- Misses        963      967       +4     
  Partials       27       27
Impacted Files Coverage Δ
src/modules/location/index.ts 99.02% <100.00%> (-0.17%) ⬇️

... and 5 files with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented May 2, 2023

IMO we should phrase the description similar to street or vice versa.

@ST-DDT ST-DDT linked an issue May 2, 2023 that may be closed by this pull request
Merge faker.location.city() and faker.location.cityName() #2021
Closed
@ST-DDT ST-DDT enabled auto-merge (squash) May 3, 2023 16:47
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 3, 2023
@ST-DDT ST-DDT merged commit 97657b1 into next May 4, 2023
@ST-DDT ST-DDT deleted the docs/location/change-city-wording branch May 4, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: docs Improvements or additions to documentation m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Merge faker.location.city() and faker.location.cityName()
4 participants
@xDivisionByZerox @ST-DDT @matthewmayer @Shinigami92