refactor(finance): standardize arguments #1821
Conversation
xDivisionByZerox
added
p: 1-normal
|
I have the save issue which I had here. This time I also did Deleting |
|
Ok, I took a closer look into the actual errors in the pipeline. Due to my locale machine being setup with different localization than the CI one and A quick fix would be to only call parameters for the snapshots which take the "non-localized" code path. But that doesn't solve the real issue behind this. |
|
I feel it should call toLocaleString(faker.locale) so it's not dependent on your current environments locale |
|
The |
What changed so that you only get the error now and not before? |
If you replace - with _ you usually have a valid locale string (en, es_MX etc). As a fallback, you could catch a |
It seems all the locales work without errors if you do this replacement: Object.keys(faker.locales).forEach(fakerLocale => {
try {
const [validLocale] = Intl.getCanonicalLocales(fakerLocale.replace(/_/g, '-'));
console.log(fakerLocale, validLocale, ((1234567.89).toLocaleString(validLocale)))
} catch (e) {
console.error("ERROR ON " + fakerLocale +" " +e)
}
})af_ZA af-ZA 1 234 567,89
ar ar ١٬٢٣٤٬٥٦٧٫٨٩
az az 1.234.567,89
cz cz 1,234,567.89
de de 1.234.567,89
de_AT de-AT 1 234 567,89
de_CH de-CH 1’234’567.89
dv dv 1,234,567.89
el el 1.234.567,89
en en 1,234,567.89
en_AU en-AU 1,234,567.89
en_AU_ocker en-AU-ocker 1,234,567.89
en_BORK en-Bork 1,234,567.89
en_CA en-CA 1,234,567.89
en_GB en-GB 1,234,567.89
en_GH en-GH 1,234,567.89
en_IE en-IE 1,234,567.89
en_IN en-IN 12,34,567.89
en_NG en-NG 1,234,567.89
en_US en-US 1,234,567.89
en_ZA en-ZA 1 234 567,89
es es 1.234.567,89
es_MX es-MX 1,234,567.89
fa fa ۱٬۲۳۴٬۵۶۷٫۸۹
fi fi 1 234 567,89
fr fr 1 234 567,89
fr_BE fr-BE 1 234 567,89
fr_CA fr-CA 1 234 567,89
fr_CH fr-CH 1 234 567,89
fr_LU fr-LU 1.234.567,89
ge ge 1,234,567.89
he he 1,234,567.89
hr hr 1.234.567,89
hu hu 1 234 567,89
hy hy 1 234 567,89
id_ID id-ID 1.234.567,89
it it 1.234.567,89
ja ja 1,234,567.89
ko ko 1,234,567.89
lv lv 1 234 567,89
mk mk 1.234.567,89
nb_NO nb-NO 1 234 567,89
ne ne १२,३४,५६७.८९
nl nl 1.234.567,89
nl_BE nl-BE 1.234.567,89
pl pl 1 234 567,89
pt_BR pt-BR 1.234.567,89
pt_PT pt-PT 1 234 567,89
ro ro 1.234.567,89
ru ru 1 234 567,89
sk sk 1 234 567,89
sv sv 1 234 567,89
tr tr 1.234.567,89
uk uk 1 234 567,89
ur ur 1,234,567.89
vi vi 1.234.567,89
zh_CN zh-CN 1,234,567.89
zh_TW zh-TW 1,234,567.89
zu_ZA zu-ZA 1,234,567.89 |
Yes. In |
Maybe revert that added test and create a separate issue for that bug. |
|
calling toLocaleString with an undefined first parameter just seems like a Bad Idea, because it makes the output of Faker dependent on the system locale rather than the Faker locale. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1821 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 2346 2346
Lines 235735 236394 +659
Branches 1141 1143 +2
==========================================
+ Hits 234869 235524 +655
- Misses 844 848 +4
Partials 22 22
|
Part of #1349.
Standardize all function signatures in the
FinanceModuleto support an options object (if they have parameters).