Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(company): deprecate suffix methods #1719

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 8, 2023

The company suffixes are just parts of the name but don't carry any use by themselves.

The locale data for the suffixes won't be removed in v9, the suffixes are just no longer directly accessible.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module deprecation A deprecation was made in the PR labels Jan 8, 2023
@ST-DDT ST-DDT requested review from a team January 8, 2023 15:50
@ST-DDT ST-DDT self-assigned this Jan 8, 2023
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #1719 (61fd9b8) into next (099e76c) will decrease coverage by 0.00%.
The diff coverage is 91.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1719      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2336     2336              
  Lines      241123   241146      +23     
  Branches     1102     1102              
==========================================
+ Hits       240241   240262      +21     
- Misses        861      863       +2     
  Partials       21       21              
Impacted Files Coverage Δ
src/definitions/company.ts 0.00% <0.00%> (ø)
src/modules/company/index.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 changed the title chore(company): deprecate suffix methods refactor(company): deprecate suffix methods Jan 9, 2023
@Shinigami92 Shinigami92 enabled auto-merge (squash) January 9, 2023 19:04
@Shinigami92 Shinigami92 merged commit 1e7534e into next Jan 9, 2023
@ST-DDT ST-DDT deleted the deprecate/company/suffix branch January 9, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions deprecation A deprecation was made in the PR m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants