Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: repair all functional test #1718

Merged
merged 12 commits into from
Jan 10, 2023
Merged

test: repair all functional test #1718

merged 12 commits into from
Jan 10, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 8, 2023 •
edited
Loading

Fixes various problems with the all functional tests:

  • grafik
  • fakerAZ.company.suffixes returns [] but is marked as valid
  • faker.helpers.fake tests often shows up as valid even if the return "value" is not
  • It is currently not possible to exclude a method from the tests for all locales
  • Obsolete configuration exists and isn't marked for removal

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Jan 8, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Jan 8, 2023
@ST-DDT ST-DDT requested review from a team January 8, 2023 15:34
@ST-DDT ST-DDT self-assigned this Jan 8, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 8, 2023

Required for #1717

@ST-DDT ST-DDT mentioned this pull request Jan 8, 2023
Merged
@codecov
Copy link

codecov bot commented Jan 8, 2023 •
edited
Loading

Codecov Report

Merging #1718 (2d2300e) into next (1e7534e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1718   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2336     2336           
  Lines      241146   241146           
  Branches     1102     1102           
=======================================
  Hits       240262   240262           
  Misses        863      863           
  Partials       21       21

@ST-DDT ST-DDT requested review from xDivisionByZerox and a team January 8, 2023 16:43
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team January 8, 2023 18:25
ST-DDT
ST-DDT commented Jan 8, 2023
View reviewed changes
test/all_functional.spec.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team January 9, 2023 19:02
@ST-DDT ST-DDT merged commit 7e0de02 into next Jan 10, 2023
@ST-DDT ST-DDT deleted the test/repair-all-functional branch January 10, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: test p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox