-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lower target to support Webpack 4 #1085
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 2135 2135
Lines 229241 229241
Branches 980 978 -2
==========================================
- Hits 228432 228427 -5
- Misses 788 793 +5
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a CI run for node14.6 or at least the lowest target we support
See also #1052 for my own tries
For tomorrows meeting: I personally find it totally weird that we need to support >2 years old out of date packages, and even if this lowers our target I lost trust in esbuild a bit, because of evanw/esbuild#2315 ... oops, this turned into a little rant ... 😅 |
Shini and I spoke. We'll be supporting es2019 + Webpack 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally do not understand how this works but if you ensure that it does I'm fine with this.
This PR would fix #1073 and target es2019 instead of dropping support for Webpack 4 (which I don't think we should do -- a lot of users are still stuck on Webpack 4, despite how long it has been out).
We're mainly having issues because we use nullish coalescing internally. This requires a target of es2019 instead of es2020. https://esbuild.github.io/content-types/#javascript
Also would fix cypress-io/cypress#21874