Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lorempicsum.avatar): deprecate #1065

Merged
merged 7 commits into from
Jun 16, 2022
Merged

chore(lorempicsum.avatar): deprecate #1065

merged 7 commits into from
Jun 16, 2022

Conversation

xDivisionByZerox
Copy link
Member

Listed as a todo in #1044.

This PR deprecates faker.image.lorempicsum.avatar() in favor of faker.internet.avatar().

@xDivisionByZerox xDivisionByZerox added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Jun 12, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jun 12, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team June 12, 2022 12:25
@xDivisionByZerox xDivisionByZerox self-assigned this Jun 12, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner June 12, 2022 12:25
@xDivisionByZerox xDivisionByZerox mentioned this pull request Jun 12, 2022
Closed
@codecov
Copy link

codecov bot commented Jun 12, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@a448cca). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 3879869 differs from pull request most recent head 54fa0ed. Consider uploading reports for the commit 54fa0ed to get more accurate results

@@           Coverage Diff           @@
##             main    #1065   +/-   ##
=======================================
  Coverage        ?   99.65%           
=======================================
  Files           ?     2135           
  Lines           ?   229170           
  Branches        ?      979           
=======================================
  Hits            ?   228368           
  Misses          ?      781           
  Partials        ?       21
Impacted Files Coverage Δ
src/modules/image/providers/lorempicsum.ts 94.85% <100.00%> (ø)

@xDivisionByZerox
Copy link
Member Author

The failing pipeline is due to some problem in the post-install script for simple-git-hooks. So not due to my implementation changes.

ST-DDT
ST-DDT previously approved these changes Jun 12, 2022
View reviewed changes
@ST-DDT ST-DDT requested review from a team June 12, 2022 15:38
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Jun 12, 2022
import-brain
import-brain previously approved these changes Jun 13, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team June 13, 2022 19:44
Shinigami92
Shinigami92 requested changes Jun 14, 2022
View reviewed changes
test/image.spec.ts Outdated Show resolved Hide resolved
import-brain
import-brain previously approved these changes Jun 14, 2022
View reviewed changes
Shinigami92
Shinigami92 previously approved these changes Jun 14, 2022
View reviewed changes
@ST-DDT ST-DDT dismissed stale reviews from Shinigami92 and import-brain via 3879869 June 14, 2022 19:40
@ST-DDT ST-DDT requested review from a team June 14, 2022 19:41
@Shinigami92 Shinigami92 enabled auto-merge (squash) June 16, 2022 17:24
@Shinigami92 Shinigami92 merged commit 804bf70 into main Jun 16, 2022
@Shinigami92 Shinigami92 deleted the chore/lorempicsum/deprecate-avatar branch June 16, 2022 17:31
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@xDivisionByZerox @Minozzzi
chore(lorempicsum.avatar): deprecate (faker-js#1065)
7a77177
@xDivisionByZerox xDivisionByZerox added the m: image Something is referring to the image module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain left review comments

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: chore PR that doesn't affect the runtime behavior m: image Something is referring to the image module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
4 participants
@xDivisionByZerox @ST-DDT @Shinigami92 @import-brain