-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(location)!: latitude
/longitude
returns number
#1064
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1064 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 2164 2164
Lines 236854 236852 -2
Branches 1004 1002 -2
==========================================
- Hits 235991 235977 -14
- Misses 842 854 +12
Partials 21 21
|
Considering the other PR, we should consider whether we want to introduce a format parameter instead. |
I really dislike the idea. For me, it doesn't make sense that coordinates would be strings. But we (as a library) should allow stringified strings as input parameters due to the nature of JS and enhancing the dx when using Faker. |
Further discussion regarding that topic please in #1066 or a separate issue/discussion. |
f094a7f
to
581bcd2
Compare
581bcd2
to
dc703e6
Compare
I eagerly put the PR title to scope in v8.0 and this will then be grouped together |
latitude
/longitude
returns number
@xDivisionByZerox needs rebase |
eba83ad
I tried to solve it, via the GitHub UI |
This PR changes to return type of
address.latitude()
andaddress.longitude()
fromstring
tonumber
.Related to #1058.
This is a breaking change! Do not merge until the next major release.