Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(unsplash): deprecate unused const #1046

Merged
merged 11 commits into from
Jun 17, 2022
Merged

chore(unsplash): deprecate unused const #1046

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
85e964c
chore: replace array with getter
import-brain Jun 11, 2022
152d1ca
Merge branch 'main' into remove_unused_const
import-brain Jun 11, 2022
5feb9bd
chore: add deprecation log
import-brain Jun 12, 2022
d45a644
test: add deprecation log test
import-brain Jun 12, 2022
6061066
Update src/modules/image/providers/unsplash.ts
import-brain Jun 12, 2022
791a9d9
test: fix test to account for updated version
import-brain Jun 13, 2022
b903551
revert: test: image.spec.ts
import-brain Jun 14, 2022
4bb29e2
chore: apply suggestions
ST-DDT Jun 14, 2022
2a73aaf
Merge branch 'main' into remove_unused_const
ST-DDT Jun 14, 2022
69e2c36
Merge branch 'main' into remove_unused_const
import-brain Jun 16, 2022
e660c69
Merge branch 'main' into remove_unused_const
ST-DDT Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/modules/image/providers/unsplash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,19 @@ import { deprecated } from '../../../internal/deprecated';
* Module to generate links to random images on `https://source.unsplash.com/`.
*/
export class Unsplash {
// TODO ST-DDT 2022-03-11: Remove unused(?) constant
categories = [
import-brain marked this conversation as resolved.
Show resolved Hide resolved
'food',
'nature',
'people',
'technology',
'objects',
'buildings',
];
/**
* Gets the list of supported unsplash categories.
*
* @deprecated
*/
get categories(): string[] {
deprecated({
deprecated: 'faker.image.unsplash.categories',
since: '7.3',
until: '8.0',
});
return ['food', 'nature', 'people', 'technology', 'objects', 'buildings'];
import-brain marked this conversation as resolved.
Show resolved Hide resolved
}

constructor(private readonly faker: Faker) {}

Expand Down