Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpkg not working #914

Closed
amchconsult opened this issue May 3, 2022 · 3 comments
Closed

unpkg not working #914

amchconsult opened this issue May 3, 2022 · 3 comments
Labels
c: bug Something isn't working has workaround Workaround provided or linked question Further information is requested

Comments

@amchconsult
Copy link

Describe the bug

<script type="text/javascript" src="https://unpkg.com/@faker-js/faker"></script>

As described on documentation is not working.
I am trying to use it on browser.

thank you

Reproduction

script type="text/javascript" src="https://unpkg.com/@faker-js/faker"></script>

Additional Info

No response
@amchconsult amchconsult added the s: pending triage Pending Triage label May 3, 2022
@Shinigami92
Copy link
Member

Yeah, I think we need to remove this from our docs as we do not bundle UMD or register the faker instance in window/globalThis.
So if unpkg is not doing some magic on its side, this will not work in any way.

Please use one of the other strategies like described here: https://fakerjs.dev/guide/#alternative-cdn-links
Also note that cdn.skypack.dev had some issues and you may want to use one of the alternative CDNs

@ST-DDT
Copy link
Member

ST-DDT commented May 3, 2022

See also: #635

@import-brain import-brain added c: bug Something isn't working question Further information is requested and removed s: pending triage Pending Triage labels May 6, 2022
@import-brain import-brain added the has workaround Workaround provided or linked label May 23, 2022
@Shinigami92
Copy link
Member

We already removed and adjusted the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: bug Something isn't working has workaround Workaround provided or linked question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ST-DDT @Shinigami92 @amchconsult @import-brain