Skypack cannot server faker 6.0

[jupegarnica]

Describe the bug

Skypack cannot server faker 6.0 so, cannot be used from deno

Reproduction

https://cdn.skypack.dev/@faker-js/[email protected]

/*
 * [Package Error] "@faker-js/[email protected]" could not be built. 
 *
 * No build output found.
 *
 * How to fix:
 *   - If you believe this to be an error in Skypack, file an issue here: https://github.com/skypackjs/skypack-cdn/issues
 *   - If you believe this to be an issue in the package, share this URL with the package authors to help them debug & fix.
 *   - Use https://skypack.dev/ to find a web-friendly alternative to find another package.
 */

console.warn("[Package Error] \"@faker-js/[email protected]\" could not be built. ");
throw new Error("[Package Error] \"@faker-js/[email protected]\" could not be built. ");
export default null;

Additional Info

No response

[jupegarnica]

the beta was working fine:

https://cdn.skypack.dev/@faker-js/[email protected]

[Shinigami92]

Yeah I see the error 🤔
I will dig into this and try find out what's different between beta.0 and release

[Shinigami92]

I will compare builds between

https://unpkg.com/@faker-js/[email protected]/package.json and https://unpkg.com/@faker-js/[email protected]/package.json

Edit 1:

except from some chunk names, there is no difference between https://unpkg.com/@faker-js/[email protected]/dist/esm/index.js and https://unpkg.com/@faker-js/[email protected]/dist/esm/index.js

But I'm not sure if skypack uses the esm or cjs version

The cjs variant looks a little bit more differently
So I assume currently that the cjs bundling process was affected by #603 or #618 in one of the esbuild updates

Edit 2:

Oh damn... yeah definitely https://github.com/evanw/esbuild/blob/HEAD/CHANGELOG.md#01427 broke it!
I will report regression to @evanw

[Shinigami92]

I ensured that the cjs version is running locally in my test folder. So this bug only affects skypack somehow 🤔

I added the label s: on hold as an intent to mark this as waiting on upstream. We don't have a label for that (yet) and I'm not sure if we need such a label.

We could downgrade to esbuild 0.14.26, but I would more like to wait on > 0.14.27 as a fix

[hyrious]

This might be a skypack issue which depends on the "default" field existing in the export: skypackjs/skypack-cdn#269

As a contrast, esm.sh and esm.run both work fine.

[Shinigami92]

Perfect, thank you @hyrious
We will update the links in docs to mention this links 👍