Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(string): generate string from characters #1717

Merged
merged 11 commits into from
Jan 11, 2023
Merged

feat(string): generate string from characters #1717

merged 11 commits into from
Jan 11, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 8, 2023

Most of our string methods just bundle a set of characters together.
This PR adds a method that simplifies that by providing a specific method for exactly that but with dynamic input characters.

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision m: string Something is referring to the string module labels Jan 8, 2023
@ST-DDT ST-DDT requested review from a team January 8, 2023 14:35
@ST-DDT ST-DDT self-assigned this Jan 8, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 8, 2023

Might be useful for #1716 as well.

@ST-DDT ST-DDT mentioned this pull request Jan 8, 2023
Merged
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 8, 2023

Blocked by #1718

@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Jan 8, 2023
@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Merging #1717 (f554b03) into next (f4615e1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f554b03 differs from pull request most recent head cb4777d. Consider uploading reports for the commit cb4777d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1717      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2336     2336              
  Lines      241146   241141       -5     
  Branches     1102     1088      -14     
==========================================
- Hits       240262   240257       -5     
  Misses        863      863              
  Partials       21       21
Impacted Files Coverage Δ
src/modules/string/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT marked this pull request as ready for review January 10, 2023 20:09
Shinigami92
Shinigami92 reviewed Jan 10, 2023
View reviewed changes
src/modules/string/index.ts Outdated Show resolved Hide resolved
src/modules/string/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team January 10, 2023 20:58
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Jan 10, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) January 11, 2023 18:49
@ST-DDT ST-DDT merged commit 47b2cfc into next Jan 11, 2023
@ST-DDT ST-DDT deleted the feat/string/fromChars branch January 11, 2023 18:59
@xDivisionByZerox xDivisionByZerox mentioned this pull request Jan 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: feature Request for new feature m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox