chore: add support for readonly arrays (#189)

Co-authored-by: Shinigami <[email protected]>
faker-js · Jan 19, 2022 · ec4efba · ec4efba
1 parent bd251ed
commit ec4efba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/helpers.ts b/src/helpers.ts
@@ -17,7 +17,7 @@ export class Helpers {
    * @method faker.helpers.randomize
    * @param array
    */
-  randomize<T = string>(array: T[] = ['a', 'b', 'c'] as unknown as T[]): T {
+  randomize<T = string>(array: ReadonlyArray<T> = ['a', 'b', 'c'] as unknown as ReadonlyArray<T>): T {
     return this.faker.random.arrayElement(array);
   }
 

diff --git a/src/random.ts b/src/random.ts
@@ -72,7 +72,7 @@ export class Random {
    * @method faker.random.arrayElement
    * @param array
    */
-  arrayElement<T = string>(array: T[] = ['a', 'b', 'c'] as unknown as T[]): T {
+  arrayElement<T = string>(array: ReadonlyArray<T> = ['a', 'b', 'c'] as unknown as ReadonlyArray<T>): T {
     const r = this.faker.datatype.number({ max: array.length - 1 });
     return array[r];
   }
@@ -85,7 +85,7 @@ export class Random {
    * @param count number of elements to pick
    */
   arrayElements<T>(
-    array: T[] = ['a', 'b', 'c'] as unknown as T[],
+    array: ReadonlyArray<T> = ['a', 'b', 'c'] as unknown as ReadonlyArray<T>,
     count?: number
   ): T[] {
     if (typeof count !== 'number') {