fix: alphaNumeric all chars banned (#550)

faker-js · Mar 21, 2022 · c51fb15 · c51fb15
1 parent 5a15c40
commit c51fb15
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/random.ts b/src/random.ts
@@ -479,11 +479,17 @@ export class Random {
       'y',
       'z',
     ];
-    if (options) {
-      if (options.bannedChars) {
-        charsArray = arrayRemove(charsArray, options.bannedChars);
-      }
+
+    if (options.bannedChars) {
+      charsArray = arrayRemove(charsArray, options.bannedChars);
     }
+
+    if (charsArray.length === 0) {
+      throw new Error(
+        'Unable to generate string, because all possible characters are banned.'
+      );
+    }
+
     for (let i = 0; i < count; i++) {
       wholeString += this.faker.random.arrayElement(charsArray);
     }

diff --git a/test/random.spec.ts b/test/random.spec.ts
@@ -210,7 +210,7 @@ describe('random', () => {
       expect(alphaText).match(/[b-oq-z]/);
     });
 
-    it.todo('should throw if all possible characters being banned', () => {
+    it('should throw if all possible characters being banned', () => {
       const bannedChars = 'abcdefghijklmnopqrstuvwxyz0123456789'.split('');
       expect(() =>
         faker.random.alphaNumeric(5, {