refactor(internet): standardize signatures (#1845)

Co-authored-by: ST-DDT <[email protected]> Co-authored-by: Shinigami <[email protected]>
faker-js · Mar 14, 2023 · a943353 · a943353
1 parent c2b21d8
commit a943353
Show file tree

Hide file tree

Showing 5 changed files with 1,318 additions and 103 deletions.
diff --git a/docs/guide/usage.md b/docs/guide/usage.md
@@ -148,7 +148,7 @@ function createRandomUser(): User {
   const sex = faker.person.sexType();
   const firstName = faker.person.firstName(sex);
   const lastName = faker.person.lastName();
-  const email = faker.internet.email(firstName, lastName);
+  const email = faker.internet.email({ firstName, lastName });
 
   return {
     _id: faker.datatype.uuid(),

diff --git a/src/modules/git/index.ts b/src/modules/git/index.ts
@@ -115,9 +115,9 @@ export class GitModule {
     const firstName = this.faker.person.firstName();
     const lastName = this.faker.person.lastName();
     const fullName = this.faker.person.fullName({ firstName, lastName });
-    const username = this.faker.internet.userName(firstName, lastName);
+    const username = this.faker.internet.userName({ firstName, lastName });
     let user = this.faker.helpers.arrayElement([fullName, username]);
-    const email = this.faker.internet.email(firstName, lastName);
+    const email = this.faker.internet.email({ firstName, lastName });
 
     // Normalize user according to https://github.com/libgit2/libgit2/issues/5342
     user = user.replace(/^[\.,:;"\\']|[\<\>\n]|[\.,:;"\\']$/g, '');