actually change the thumbnail size to 400h (mozilla#16770)

* actually change the thumbnail size to 400h * update tests too
fakegit · Mar 17, 2021 · 47191f6 · 47191f6
1 parent 9549aab
commit 47191f6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/olympia/constants/base.py b/src/olympia/constants/base.py
@@ -227,9 +227,9 @@
 ADDON_ICON_SIZES = [32, 64, 128]
 
 _dimensions = namedtuple('SizeTuple', 'width height')
-# Preview upload sizes - see mozilla/addons-server#9487 for background.
+# Preview upload sizes - see mozilla/addons-server#9487 & #16717 for background.
 ADDON_PREVIEW_SIZES = {
-    'thumbnail': _dimensions(640, 480),
+    'thumbnail': _dimensions(533, 400),
     'min': _dimensions(1000, 750),
     'full': _dimensions(2400, 1800),
     'thumbnail_format': 'jpg',

diff --git a/src/olympia/devhub/tests/test_forms.py b/src/olympia/devhub/tests/test_forms.py
@@ -353,7 +353,7 @@ def test_preview_size(self, pngcrush_image_mock):
         assert preview.sizes == (
             {
                 'image': [2400, 1600],
-                'thumbnail': [640, 427],
+                'thumbnail': [533, 355],
                 'original': [3000, 2000],
                 'thumbnail_format': 'jpg',
             }

diff --git a/src/olympia/devhub/tests/test_tasks.py b/src/olympia/devhub/tests/test_tasks.py
@@ -157,7 +157,7 @@ def test_recreate_previews(pngcrush_image_mock):
 
     assert preview_has_original.reload().sizes == {
         'image': [2400, 1600],
-        'thumbnail': [640, 427],
+        'thumbnail': [533, 355],
         'original': [3000, 2000],
         'thumbnail_format': 'jpg',
     }