Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Block, Paragraph, Word, Symbol models for Full Text Annotation #11

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

HighLiuk
Copy link
Contributor

@HighLiuk HighLiuk commented Sep 3, 2023

Models are based on the Google Cloud Vision API's docs

@faithoflifedev faithoflifedev merged commit e8bab50 into faithoflifedev:main Sep 5, 2023
@faithoflifedev
Copy link
Owner

@HighLiuk , thanks for helping with the package.

In running some checks after merging your PR, I'm seeing some Warnings (unrelated to your changes), so I've submitted a PR appsup-dart/x509#25 to the https://pub.dev/packages/x509 package to resolve that. I'm hoping that the x509 package will get updated and then I can published these changes. If x509 isn't updated soon, then I'll publish regardless, since the issue is just warnings.

@HighLiuk
Copy link
Contributor Author

HighLiuk commented Sep 5, 2023

Thanks @faithoflifedev for the clarification. I have one more (unrelated) improvement if you are interested into it.
Check it out at my dev branch.
I may make a PR for that if you want to.
The purpose is to let GoogleVision to be initialized by passing the google-credentials.json file by only knowing its contents. Otherwise you have to make workarounds like saving a temporary file with that just to read the credentials.

P.S. not sure that JwtFromStringGeneratoris a proper name for that.

HighLiuk pushed a commit to HighLiuk/google_vision that referenced this pull request Dec 18, 2023
Add Block, Paragraph, Word, Symbol models for Full Text Annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants