Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List and count shootings #80

Merged
merged 1 commit into from
Apr 18, 2021
Merged

List and count shootings #80

merged 1 commit into from
Apr 18, 2021

Conversation

mmarchois
Copy link
Contributor

Cette PR permet de lister les prises de vues.
Toutes les photos seront désormais reliées à une prise de vue (et non à une école) qui a une date de prise de vue et une date limite de commande.

@mmarchois mmarchois added the photographer This issue or pull request already exists label Apr 18, 2021
@mmarchois mmarchois self-assigned this Apr 18, 2021
@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #80 (fc21c35) into master (d35d867) will decrease coverage by 0.11%.
The diff coverage is 89.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   93.35%   93.24%   -0.12%     
==========================================
  Files         161      166       +5     
  Lines        1565     1598      +33     
  Branches       64       64              
==========================================
+ Hits         1461     1490      +29     
- Misses        104      108       +4     
Impacted Files Coverage Δ
...astructure/School/Repository/ShootingRepository.ts 41.66% <0.00%> (-20.84%) ⬇️
...hool/Query/Shooting/CountShootingsBySchoolQuery.ts 100.00% <100.00%> (ø)
...ery/Shooting/CountShootingsBySchoolQueryHandler.ts 100.00% <100.00%> (ø)
...School/Query/Shooting/GetShootingsBySchoolQuery.ts 100.00% <100.00%> (ø)
...Query/Shooting/GetShootingsBySchoolQueryHandler.ts 100.00% <100.00%> (ø)
api/src/Application/School/View/ShootingView.ts 100.00% <100.00%> (ø)
api/src/Domain/School/Shooting.entity.ts 96.77% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35d867...fc21c35. Read the comment docs.

@mmarchois mmarchois merged commit 6703910 into master Apr 18, 2021
@mmarchois mmarchois deleted the feat/list-shootigs branch April 18, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
photographer This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant