Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only require importlib_metadata for Python<3.8 #59

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Only require importlib_metadata for Python<3.8 #59

merged 2 commits into from
Dec 4, 2023

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Nov 23, 2023

No description provided.

mikedarcy
mikedarcy requested changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@mikedarcy mikedarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see review comments.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@mr-c mr-c force-pushed the version_importlib_metadata_dep branch from 4b7525f to 221ec97 Compare November 30, 2023 10:12
@mikedarcy mikedarcy merged commit 8ee2850 into fair-research:master Dec 4, 2023
6 checks passed
@mr-c mr-c deleted the version_importlib_metadata_dep branch December 4, 2023 18:30
@mr-c mr-c restored the version_importlib_metadata_dep branch December 4, 2023 18:30
@mr-c mr-c deleted the version_importlib_metadata_dep branch December 4, 2023 18:30
@mr-c
Copy link
Contributor Author

mr-c commented Dec 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedarcy mikedarcy mikedarcy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-c @mikedarcy