Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thread-local version? #50

Open
madsmtm opened this issue Oct 29, 2024 · 1 comment
Open

Add thread-local version? #50

madsmtm opened this issue Oct 29, 2024 · 1 comment

Comments

@madsmtm
Copy link

madsmtm commented Oct 29, 2024

Would it make sense to have a non-thread safe version for thread-local executors like unsend?

This could be more performant (both because it could use LocalWaker once stable, and because it could use Cell/Rc instead of atomics) and the implementation would probably be simpler.
notgull added a commit to notgull/unsend that referenced this issue Oct 30, 2024
@notgull
feat: Add oneshot channel
8dd4234 
This is a missing addition to the Unsend ecosystem. This API adds a
oneshot channel with the classic send/recv model.

ref faern/oneshot#50

Signed-off-by: John Nunley <[email protected]>
@notgull notgull mentioned this issue Oct 30, 2024
Open
@faern
Copy link
Owner

faern commented Oct 30, 2024

I have not looked into the details of what would be required to implement this. But it sounds like this would be a completely different type and implementation, and with a quite niche use case? So with that in mind I would maybe argue that it belongs more in a separate crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faern @madsmtm