This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this repository available! Had to make some minor tweaks to get it building with foxy.
Namely:
rosbag
package is nowrosbag2_cpp
get_typesupport
has been split intoget_typesupport_library
andget_typesupport_handle
Something that tripped me up - the client library needs to persist a shared pointer to the library for the lifetime of any typesupport handles.