Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

fix: adapt to rosbag2 foxy changes #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rokel
Copy link

@rokel rokel commented Jun 12, 2020

Thanks for making this repository available! Had to make some minor tweaks to get it building with foxy.

Namely:

  • Required rosbag package is now rosbag2_cpp
  • get_typesupport has been split into get_typesupport_library and get_typesupport_handle

Something that tripped me up - the client library needs to persist a shared pointer to the library for the lifetime of any typesupport handles.

@facontidavide
Copy link
Owner

thanks a lot. But wonçt this change brake the compilation in Eloquent?

Rosbag2 is a moving target, and I have the feeling that the definitive solution is to copy and paste the code I need from there inside my library.

@rokel
Copy link
Author

rokel commented Jun 12, 2020

Fair point, I suppose the alternative would be maintaining separate branches for each release, but would be a lot of work. Feel free to close this PR, hopefully will still be useful to others :)

@facontidavide
Copy link
Owner

this PR is very useful to me to see the changes I will be supposed to do, if I move to Foxy.

Therefore i will not close it yet.

Thanks a lot

@nyxaria
Copy link

nyxaria commented Aug 20, 2020

This is awesome, thank you so much @rokel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants