Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlotJuggler with Fast-CDR-2.x.x #920

Merged
merged 4 commits into from
Jan 26, 2024
Merged

PlotJuggler with Fast-CDR-2.x.x #920

merged 4 commits into from
Jan 26, 2024

Conversation

manuelValch
Copy link
Contributor

@manuelValch manuelValch commented Jan 21, 2024 •
edited
Loading

Resolve: #919 #861

I would like to be able to use PlotJuggler with the latest fast-CDR from eProsima which is why I propose:

  • Update local thirdparty files from eProsima to version 2.x.x
  • Update cmake version so that it is possible to compile with fastcdr installed on the dev machine.

Tested with eProsima helloword example: Ok
Capture d’écran du 2024-01-21 16-21-28

Helloworld example: https://fast-dds.docs.eprosima.com/en/latest/fastdds/getting_started/simple_app/simple_app.html

Configuration file: https://plotjuggler-fastdds-plugins.readthedocs.io/en/latest/rst/user_manual/configuration.html

configuration file to be able to read from a Topic:

<types>
    <type>
        <struct name="HelloWorld">
            <member name="index" type="uint32"/>
            <member name="message" type="string"/>
        </struct>
    </type>
</types>

tested on:

Static hostname: ubuntu-H610M-S2H-DDR4
       Icon name: computer-desktop
         Chassis: desktop
      Machine ID: f15bb09bbaa74f77be0ee3e9db35aca0
         Boot ID: ec841c97061f43a89768b3b36538327f
Operating System: Ubuntu 22.04.3 LTS              
          Kernel: Linux 6.5.0-14-generic
    Architecture: x86-64
 Hardware Vendor: Gigabyte Technology Co., Ltd.
  Hardware Model: H610M S2H DDR4

with PlotJuggler version 3.8.8

manuelValch added 2 commits January 21, 2024 13:57
Update minimum cmake version
3072128 
Updated minimum cmake version otherwise fastcdr find package fails.
As the issue is about building with fastcdr installed from eProsima
reposotories I need it to work.

Issues
[facontidavide#861]
[facontidavide#919]
Update Fast-CDR thirdparty
85ecccf 
If this commit is applied then plotjuggler will be able to compile and
run with Fast-CDR version 2.x.x from eProsima.
It can compile from:
- local thirdparty folder included within the repo
- install of fastcdr within the machine (usually /usr/local)

to do so:
- Udpated files, API and namespace names

Done it because I need to use plotJuggler with latest lib from eProsima
and I would like this to be available for everyone.

Issue:
[facontidavide#919]
@facontidavide
Copy link
Owner

CI is red...

@manuelValch
Copy link
Contributor Author

CI is red...

Ok will have a look to fix

Fix CI, added missing files
dc8e6c2 
Added missing files from Fastcdr Ci shall build.
PlotJuggler build again with or without fastcdr package installed.

Issue:
[facontidavide#919]
@manuelValch
Copy link
Contributor Author

manuelValch commented Jan 25, 2024 •
edited
Loading

Hello so now it builds in local with or without fastcdr installed (sorry i should have double checked).

Tested with a csv import.
Though is there a guide to test cdr deserealisation with example ros files from datasamples/rosbag2_test/ (I am very new to ros2 world).

tested also with fastDDS demo project, I am able to see index from helloworldTopic:

image

whith this csv export (which I can also visualize after a load):
exportHelloWorldTopic.csv

facontidavide
facontidavide requested changes Jan 26, 2024
View reviewed changes
CMakeLists.txt Outdated
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.10.2)
cmake_minimum_required(VERSION 3.27.2)
Copy link
Owner

@facontidavide facontidavide Jan 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For compatibility with Ubuntu 20.04, can this be 3.16.3?

Otherwise, I can not accept this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test and come back to you

facontidavide
facontidavide reviewed Jan 26, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@facontidavide facontidavide merged commit 3d13507 into facontidavide:main Jan 26, 2024
6 of 11 checks passed
@facontidavide
Copy link
Owner

This PR broke the compilation. I will revert it.

Once it is fixed in the ROS industrial CI, you can submit it again

facontidavide added a commit that referenced this pull request Jan 26, 2024
@facontidavide
Revert "PlotJuggler with Fast-CDR-2.x.x (#920)"
5b76d83 
This reverts commit 3d13507.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facontidavide facontidavide facontidavide requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlotJuggler does not build with fast-CDR version 2.x.x
2 participants
@manuelValch @facontidavide