fix(snap): remove yaml grade #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grade is set from the part YAML grade has priority over the programmed one so we remove it
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this comment: #714 (comment)
We realized that releasing the snap to a stable branch wasn't working.
The
gradewas programmatically set during the pull of the PlotJuggler part. But the YAML was also setting thegrade.And the YAML file has the priority: https://github.com/facontidavide/PlotJuggler/runs/7689122227?check_suite_focus=true#step:3:14109
Removing the
gradefrom the YAML solves the problem.Sorry for the inconvenience.