Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly alters the snap, resulting in the following user experience,
Install the snap,
sudo snap install plutjuggler
Launch the snap with ROS support,
plotjuggler
This is also achieved hitting the desktop launcher. It is on par with the behaviour of the current ‘stable’ snap. So far, no disruption for users.
The actual change is the introduction of two new commands,
plotjuggler.ros
plotjuggler.ros2
Which respectively (explicitly) launch PJ with ROS or ROS 2 support.
Finally, users are able to change the behaviour of the ‘plotjuggler’ command as follows,
sudo snap set plotjuggler ros-plugin-version=2
So that the command now launches PJ with ROS 2 support instead of ROS.
This change is the result of fixing the issue with loading rosbags.
Being able to load rosbag brought up two main problems:
libclass_loader.so
) both ROS/ROS 2 plugins cannot be loaded at the same timemetadata.yaml
are referring to the.db3
file relatively. In snaps GUI with Qt, files loaded withQFileDialog
are fuse-mounted to/run/user/<uid>/doc/<hash>/
in order to give your snapped application access to it (from the xdg-desktop-portals). The.db3
file is then searched within/run/user/<uid>/doc/<hash>/
which only contains themetadata.yaml
.This PR also includes:
This PR does not disrupt any existing install while bringing ROS 2 support along with an explicit command.
Feel free to ask any questions regarding the snap or its usage.