Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example configuration using url instead of multiple parameters #24

Closed
wants to merge 1 commit into from
Closed

Conversation

samvdb
Copy link

@samvdb samvdb commented Nov 29, 2017

No description provided.

@samvdb
Copy link
Author

samvdb commented Jan 17, 2018

Can we merge this?

```yaml
# Doctrine example Configuration
parameters:
# Adds a fallback DATABASE_URL if the env var is not set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. If the cache warmup triggers a DB connection in Doctrine it's not this lib's fault, but it's due to the fact that you didn't specify a DB version/charset in the connection, so Doctrine is forced to connect to it to obtain those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samvdb
may you change the PR accordingly with @Jean85 suggestion?
should be really fast, then we'll merge this.
thanks,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samvdb any update on this?

@antondemanov
Copy link

Usage example with url is very needed in the readme. I've spent a lot of time finding the root of problem, which is in scheme in DATABASE_URL (doctrine/dbal#3209)

@peelandsee
Copy link
Member

no answer from @samvdb,
closing this now

@peelandsee peelandsee closed this Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants