-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade GitHub Actions #180
Conversation
Also, remove redundant settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While there may be some good things in here, there are a lot of large, opinionated decisions being made about how we should perform our actions in this PR. I would have appreciated a discussion first about the proposed changes as that would have saved you some time.
I don't mind upgrading actions, I also don't mind removing deadsnakes. I'm also not against bumping max-parallel
, but I don't think I'm interested in the other changes.
Why is Python 3.11 not a |
Originally, I was trying out the "required" tests option. I always forget to update new tests and remove old tests. I don't have non-required tests, so I will remove the "required" settings. |
Added |
I guess I am okay with docs and lint as they do appear separate now. I do need |
Yeah, as soon as you include one, the tests don't run unless they are all defined, which is why I just define them all. |
Thanks for your patience, I think everything looks okay now. @gir-bot lgtm |
Also, remove redundant settings.