Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in mem_eff kernel with attention mask and MQA #952

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix bug in mem_eff kernel with attention mask and MQA #952

merged 1 commit into from
Feb 23, 2024

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Dec 21, 2023

What does this PR do?

Fixes issues originally reported here pytorch/pytorch#112577

Before submitting

  • [x ] Did you have fun?
    • Make sure you had fun coding 🙃
  • [ x] Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2023
@bottler bottler requested a review from danthe3rd January 11, 2024 18:10
@danthe3rd danthe3rd merged commit 4f7ffaa into main Feb 23, 2024
8 checks passed
@danthe3rd danthe3rd deleted the fix_mem_eff_masking_mqa_bug branch February 23, 2024 13:43
danthe3rd
danthe3rd reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@danthe3rd danthe3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Sorry for the delay in reviewing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danthe3rd danthe3rd danthe3rd left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drisspg @danthe3rd @facebook-github-bot