Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Populate database using the files in xlogfile #321

Merged
merged 1 commit into from
May 17, 2022

Conversation

cdmatters
Copy link
Contributor

ttyrecname= when writing ttyrecs.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2022
@cdmatters cdmatters changed the title Change add_nledata_directory to use the fact that xlogfiles now have Populate database using the files in xlogfile May 16, 2022
@cdmatters
Copy link
Contributor Author

Prior to #319 , we populated the dataset's database by matching up rows in the xlogfile to the the reset suffix in nle.<process>.<reset>.ttyrec<version>.bz2.

This was clearly prone to mistakes when an episode was terminated (eg: hitting reset() before done is True), which would introduce offset errors. Now that the file has been added to the xlogfile, we can directly use this information to populate the db, removing this error.

Copy link

@drothermel drothermel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, nice!

@cdmatters cdmatters merged commit 962ca2e into main May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants