This repository has been archived by the owner on May 6, 2024. It is now read-only.
Updates to cmake #310
Merged
Updates to cmake #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
In this special case, dat/dungeon etc exists and CMake picks up on that file instead of the generated one, re-introducing the race condition on makedefs -e and dlb cf nhdat.
heiner
force-pushed
the
heiner/cmake-updates
branch
from
f8ce0b3
to
3ac9049
Compare
A cherry-picking failure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns our NLE cmake files with my proposal for a CMake-based NetHack-build, here and here. In particular it adds some defensive measures when building NLE with cmake after building some artefacts with NetHack's Makefile setup.
The change in of not using
$<TARGET_FILE:...>generators as theCOMMANDofadd_custom_commandcomes from feedback from a PR for NetHack.