Fix a bad buffer overflow in inv_strs.

facebookresearch · Jun 5, 2021 · 36db803 · 36db803
1 parent cf877c2
commit 36db803
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/win/rl/winrl.cc b/win/rl/winrl.cc
@@ -384,7 +384,9 @@ NetHackRL::fill_obs(nle_obs *obs)
         int i = 0;
         for (const rl_inventory_item &item : inventory_) {
             int j = 0;
-            for (int size = item.str.size(); j < size; ++j) {
+            for (int size =
+                     std::min(item.str.size(), NLE_INVENTORY_STR_LENGTH);
+                 j < size; ++j) {
                 obs->inv_strs[i++] = item.str[j];
             }
             for (; j < NLE_INVENTORY_STR_LENGTH; ++j) {