-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow repetitions for Choice parameters #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrapin
added
Type: Enhancement
New feature or request
Status: In Progess
Priority: High
Difficulty: High
labels
May 12, 2020
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
May 12, 2020
30 times faster In [16]: %cpaste -q
import time
import nevergrad as ng
t0 = time.time()
param = ng.p.Tuple(*[ng.p.Choice(range(64)) for _ in range(100000)])
param.mutate()
v = param.value
print("v1", time.time() - t0)
t0 = time.time()
param = ng.p.Choice(range(64), repetitions=100000)
param.mutate()
v = param.value
print("v2", time.time() - t0)
--
v1 104.45756006240845
v2 3.4510011672973633 |
On how many CPUs? Can you also measure using a single CPU? |
This is on my macbook pro, there is no parallelization apart from the one that may be in numpy, i think it's 1 CPU then |
Waow that one is really GREAT :-) |
teytaud
pushed a commit
that referenced
this pull request
May 25, 2020
teytaud
added a commit
that referenced
this pull request
May 25, 2020
* firstMetaModel * meta_model_for_shiva * fix * Type_fix:_.value_was_missing. Also better handling of exceptions. * Tell not asked: I'm lost. * Add recommendation. * Add recommendation. * Let us catch bad big values in metamodels. * Deactivate BO test for windows * Add metamodel in illcond tests. * fixstaticanalysis * Update optimizerlib.py * updateMetaModel (#692) * updateMetaModel * Update optimizerlib.py * Check suggest recommendation (#635) * Add basic Pylint tests (#669) * Allow repetitions for Choice parameters (#670) * firstMetaModel * meta_model_for_shiva * Update post version number * Fix repeated Choice hash (#676) * fix * Type_fix:_.value_was_missing. Also better handling of exceptions. * Tell not asked: I'm lost. * Add recommendation. * Add recommendation. * Let us catch bad big values in metamodels. * Deactivate BO test for windows * Add metamodel in illcond tests. * fixstaticanalysis * Lazy initialization in MLTuning (#673) * Fix discrete mutation in dim 1 (#679) Co-authored-by: Jeremy Rapin <[email protected]> Co-authored-by: Teytaud <[email protected]> * fix * Add an experimental bouncing bounding method (#684) * Add a tutorial for windows users (#688) * Update optimizerlib.py * updateMetaModel (#692) * updateMetaModel * Update optimizerlib.py Co-authored-by: Jeremy Rapin <[email protected]> Co-authored-by: Jérémy Rapin <[email protected]> Co-authored-by: Fabien Teytaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Do not delete this pull request or issue due to inactivity.
Difficulty: High
Priority: High
Status: In Progess
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
This seems a common scheme that could be handled more efficiently to scale better.
How Has This Been Tested (if it applies)
Checklist