-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sphere.py -- add pooling and max_pooling #1596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the same signature as other codes so that it can work in the quasi-randomize function.
Please add your code as default in quasi-randomize, when len(shape) > 1, instead of dispersion_with_big_conv.
nevergrad/common/sphere.py
Outdated
@@ -826,6 +855,8 @@ def metric_pack_big_conv(x, budget=default_budget): | |||
"Riesz_blursum_lowconv_loworder", | |||
"Riesz_blursum_lowconv_midorder", | |||
"Riesz_blursum_lowconv_highorder", | |||
"max_pooling", | |||
"pooling" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All methods in the list have the same signature, so that they can be used by quasi-randomize.
Please use the same signature.
fix signature of pooling and max_pooling
fix style
Does it run ? This does not work as Torch is not in the dependencies. Also you need black. |
remove torch dependency
black formatting
- black - change standard avg pooling size
fix black
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist