Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs / optimization : Rephrasing + fix broken code blocks #1493

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

LouisJustinTALLOT
Copy link
Contributor

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Small changes to make the optimization page of the docs more readable.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 3, 2023
@teytaud
Copy link
Contributor

teytaud commented Feb 15, 2023

Hello! For the dangerous default value I guess it will be fixed just by a rebase (git rebase).
This might even solve the other bug.
Can you give it a try ?
Have a great day!

@teytaud
Copy link
Contributor

teytaud commented Nov 21, 2023

Hello @LouisJustinTALLOT ; maybe just rebase and everything will be fine in the CI ?

@teytaud teytaud merged commit 72c7e01 into facebookresearch:main Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants